Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass slurm job failure (not a fix) #1447

Merged
merged 1 commit into from
Oct 31, 2023
Merged

pass slurm job failure (not a fix) #1447

merged 1 commit into from
Oct 31, 2023

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Oct 31, 2023

slurm always reports error even if all tests are passed. It disallows the following tests in pipeline.

Because we are busy with release deadline and the following tests are sometimes useful, we just always pass it now.
but before merge, we should check the result in the pipeline.
It should be fixed or replaced by alternative way in the future

slurm always reports error even if all tests are passed.
It should be fixed or find alternative way to do it in the future
@yhmtsai yhmtsai requested a review from a team October 31, 2023 15:37
@yhmtsai yhmtsai self-assigned this Oct 31, 2023
@ginkgo-bot ginkgo-bot added the reg:ci-cd This is related to the continuous integration system. label Oct 31, 2023
@yhmtsai yhmtsai changed the title pass slurm job failure (Not Fix) pass slurm job failure (not a fix) Oct 31, 2023
Copy link
Member

@thoasm thoasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Oct 31, 2023
@yhmtsai yhmtsai merged commit ff96919 into develop Oct 31, 2023
13 of 14 checks passed
@yhmtsai yhmtsai deleted the pass_slurm branch October 31, 2023 22:46
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. reg:ci-cd This is related to the continuous integration system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants