Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solver config #1395

Merged
merged 8 commits into from
May 27, 2024
Merged

Solver config #1395

merged 8 commits into from
May 27, 2024

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Aug 21, 2023 •
edited
Loading

This PR adds the solver config except for multigrid and the common test.

The test includes the following

  • CreateDefault: use float64, int32 as default
  • ExplicitTemplate: use different template parameters from the default and the following also uses this setting
  • SetFromRegistry: always use the data from the registry, so it should contain the same pointer as the answer
  • SetFromConfig: always use config to generate objects, so we can only check the type

TODO:

@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:testing This is related to testing. mod:core This is related to the core module. type:solver This is related to the solvers labels Aug 21, 2023
@github-actions github-actions bot deleted a comment from ginkgo-bot Nov 27, 2023
@github-actions GitHub Actions
Copy link

Error: The following files need to be formatted:

core/config/config.cpp
core/config/config.hpp
core/config/dispatch.hpp
include/ginkgo/core/config/config.hpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

@github-actions GitHub Actions
Copy link

Error: The following files need to be formatted:

core/config/config.cpp
core/config/config.hpp
core/config/dispatch.hpp
include/ginkgo/core/config/config.hpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

@yhmtsai yhmtsai force-pushed the solver_config branch 2 times, most recently from becee21 to 77aee64 Compare November 28, 2023 20:41
@yhmtsai yhmtsai self-assigned this Nov 30, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

67.8% 67.8% Coverage
3.6% 3.6% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@MarcelKoch MarcelKoch added this to the Ginkgo 1.8.0 milestone Apr 5, 2024
@yhmtsai yhmtsai added the 1:ST:ready-for-review This PR is ready for review label May 13, 2024
@yhmtsai yhmtsai force-pushed the solver_config branch 2 times, most recently from 8d87e50 to 6c71ab4 Compare May 17, 2024 08:42
@thoasm thoasm self-requested a review May 17, 2024 09:10
@upsj upsj self-requested a review May 17, 2024 09:10
thoasm
thoasm approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@thoasm thoasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is the core/config/parse_macro.hpp header, which should be removed. The rest are minor comments. Overall, it looks good to me, and I like your test setup for that many different solvers.

core/config/dispatch.hpp Outdated Show resolved Hide resolved
core/config/parse_macro.hpp Outdated Show resolved Hide resolved
core/config/solver_config.cpp Outdated Show resolved Hide resolved
include/ginkgo/core/solver/bicg.hpp Outdated Show resolved Hide resolved
core/solver/lower_trs.cpp Outdated Show resolved Hide resolved
core/solver/upper_trs.cpp Outdated Show resolved Hide resolved
core/test/config/solver.cpp Show resolved Hide resolved
core/test/config/solver.cpp Outdated Show resolved Hide resolved
@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels May 24, 2024
@yhmtsai yhmtsai force-pushed the solver_config branch 4 times, most recently from 5173c9e to c6b3ca8 Compare May 25, 2024 21:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.3% Coverage on New Code
10.2% Duplication on New Code

See analysis details on SonarCloud

Base automatically changed from factory_config to develop May 27, 2024 14:51
@yhmtsai yhmtsai merged commit 591ace6 into develop May 27, 2024
12 of 15 checks passed
@yhmtsai yhmtsai deleted the solver_config branch May 27, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoasm thoasm thoasm approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

@upsj upsj Awaiting requested review from upsj

Assignees

@yhmtsai yhmtsai

Labels
1:ST:ready-to-merge This PR is ready to merge. mod:core This is related to the core module. reg:build This is related to the build system. reg:testing This is related to testing. type:solver This is related to the solvers
Projects
None yet
Milestone
Ginkgo 1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yhmtsai @MarcelKoch @thoasm @ginkgo-bot