Skip to content

Commit

Permalink
Issue #46: converted ARGB-to-BGRA profiler to RGB-to-BGRA profiler
Browse files Browse the repository at this point in the history
  • Loading branch information
@dzhoshkun
dzhoshkun committed Apr 16, 2019
1 parent 09e1197 commit fcd8cc4
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 79 deletions.
12 changes: 6 additions & 6 deletions src/tests/rgbswap/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
SET(ARGB_TO_BGRA_PROFILER argb_to_bgra_profiler)
SET(RGB_TO_BGRA_PROFILER rgb_to_bgra_profiler)
ADD_EXECUTABLE(
${ARGB_TO_BGRA_PROFILER}
${CMAKE_SOURCE_DIR}/tests/rgbswap/profile_argb_to_bgra.cpp
${RGB_TO_BGRA_PROFILER}
${CMAKE_SOURCE_DIR}/tests/rgbswap/profile_rgb_to_bgra.cpp
)
if(USE_FFMPEG)
LIST(APPEND ARGB_TO_BGRA_PROFILER_LIBS ${FFmpeg_LIBS})
LIST(APPEND RGB_TO_BGRA_PROFILER_LIBS ${FFmpeg_LIBS})
endif(USE_FFMPEG)
if(USE_OPENCV)
LIST(APPEND ARGB_TO_BGRA_PROFILER_LIBS ${OpenCV_LIBS})
LIST(APPEND RGB_TO_BGRA_PROFILER_LIBS ${OpenCV_LIBS})
endif(USE_OPENCV)
TARGET_LINK_LIBRARIES(
${ARGB_TO_BGRA_PROFILER} ${ARGB_TO_BGRA_PROFILER_LIBS}
${RGB_TO_BGRA_PROFILER} ${RGB_TO_BGRA_PROFILER_LIBS}
)
114 changes: 41 additions & 73 deletions src/tests/rgbswap/profile_rgb_to_bgra.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#include <chrono>
#include <iostream>
#include <cstring>
#include <algorithm>
#ifdef USE_FFMPEG
extern "C" {
#include <libswscale/swscale.h>
Expand All @@ -15,34 +14,23 @@ extern "C" {
using namespace std;
using namespace std::chrono;

template<typename T>
void copy_strided(T begin , T end, T dest, int length)
bool rgb_same_as_bgra(const unsigned char *rgb,
const unsigned char *bgra,
size_t l)
{
int num_copied = 0;
copy_if(begin, end, dest, [&num_copied,length]( double x )
{
return (num_copied++ % length == 0);
}
);
}

bool argb_same_as_bgra(const unsigned char *argb,
const unsigned char *bgra,
size_t l)
{
for (size_t i = 0; i < l; i += 4)
if (argb[i] != bgra[i+3] or argb[i+1] != bgra[i+2] or
argb[i+2] != bgra[i+1] or argb[i+3] != bgra[i])
for (size_t i = 0, j = 0; i < l; i += 4, j += 3)
if (rgb[j] != bgra[i+2] or rgb[j+1] != bgra[i+1] or
rgb[j+2] != bgra[i])
return false;
return true;
}

int main(int argc, char *argv[])
{
// ARGB with random values
// RGB with random values
size_t w = 1920, h = 1080;
size_t l;
unsigned char *argb = nullptr;
unsigned char *rgb = nullptr;
bool compose = true;
if (argc == 2)
{
Expand All @@ -52,14 +40,13 @@ int main(int argc, char *argv[])
w = orig.cols;
h = orig.rows;
compose = false;
l = 4 * w * h;
argb = reinterpret_cast<unsigned char *>(malloc(l * sizeof(unsigned char)));
for (size_t i = 0, j = 0; i < l; i +=4, j += 3)
l = 3 * w * h;
rgb = reinterpret_cast<unsigned char *>(malloc(l * sizeof(unsigned char)));
for (size_t i = 0; i < l; i +=3)
{
argb[i] = 255;
argb[i+1] = orig.data[j+2];
argb[i+2] = orig.data[j+1];
argb[i+3] = orig.data[j];
rgb[i] = orig.data[i+2];
rgb[i+1] = orig.data[i+1];
rgb[i+2] = orig.data[i];
}
#endif
}
Expand All @@ -68,35 +55,35 @@ int main(int argc, char *argv[])
w = atoi(argv[1]);
h = atoi(argv[2]);
}
cout << "Profiling ARGB => BGRA conversion for "
cout << "Profiling RGB => BGRA conversion for "
<< w << " x " << h << " image" << endl;
if (compose)
{
l = 4 * w * h;
argb = reinterpret_cast<unsigned char *>(malloc(l * sizeof(unsigned char)));
l = 3 * w * h;
rgb = reinterpret_cast<unsigned char *>(malloc(l * sizeof(unsigned char)));
for (size_t i = 0; i < l; i++)
{
argb[i] = i % 32;
argb[i+1] = argb[i] * 4;
argb[i+2] = i % 256;
argb[i+3] = 255;
rgb[i] = i % 32;
rgb[i+1] = rgb[i] * 4;
rgb[i+2] = i % 256;
}
}

// ARGB => BGRA in a strided loop
// RGB => BGRA in a strided loop
l = 4 * w * h;
unsigned char *bgra_loop = nullptr;
bgra_loop = reinterpret_cast<unsigned char *>(malloc(l * sizeof(unsigned char)));
high_resolution_clock::time_point t1 = high_resolution_clock::now();
for (size_t i = 0; i < l; i += 4)
for (size_t i = 0, j = 0; i < l; i += 4, j += 3)
{
bgra_loop[i] = argb[i+3];
bgra_loop[i+1] = argb[i+2];
bgra_loop[i+2] = argb[i+1];
bgra_loop[i+3] = argb[i];
bgra_loop[i] = rgb[j+2];
bgra_loop[i+1] = rgb[j+1];
bgra_loop[i+2] = rgb[j];
bgra_loop[i+3] = 255;
}
high_resolution_clock::time_point t2 = high_resolution_clock::now();
auto duration = duration_cast<microseconds>( t2 - t1 ).count();
cout << "Loop (" << (argb_same_as_bgra(argb, bgra_loop, l) ? "success" : "failure")
cout << "Loop (" << (rgb_same_as_bgra(rgb, bgra_loop, l) ? "success" : "failure")
<< ") took: " << duration << " usec" << endl;
#ifdef USE_OPENCV
{
Expand All @@ -106,34 +93,36 @@ int main(int argc, char *argv[])
#endif
free(bgra_loop);

// simple memcopy (no ARGB => BGRA)
unsigned char *argb_memcpy = nullptr;
argb_memcpy = reinterpret_cast<unsigned char *>(malloc(l * sizeof(unsigned char)));
// simple memcopy (no RGB => BGRA)
l = 3 * w * h;
unsigned char *rgb_memcpy = nullptr;
rgb_memcpy = reinterpret_cast<unsigned char *>(malloc(l * sizeof(unsigned char)));
t1 = high_resolution_clock::now();
memcpy(argb_memcpy, argb, l * sizeof(unsigned char));
memcpy(rgb_memcpy, rgb, l * sizeof(unsigned char));
t2 = high_resolution_clock::now();
duration = duration_cast<microseconds>( t2 - t1 ).count();
cout << "memcpy took: " << duration << " usec" << endl;
free(argb_memcpy);
free(rgb_memcpy);

#ifdef USE_FFMPEG
// ARGB => BGRA using FFmpeg
l = 4 * w * h;
// RGB => BGRA using FFmpeg
unsigned char *bgra_ffmpeg = nullptr;
bgra_ffmpeg = reinterpret_cast<unsigned char *>(malloc(l * sizeof(unsigned char)));
unsigned char *srcSlice[] = {argb};
int srcStride[] = {static_cast<int>(4 * w)};
unsigned char *srcSlice[] = {rgb};
int srcStride[] = {static_cast<int>(3 * w)};
int srcSliceY = 0;
int srcSliceH = h;
unsigned char *dst[] = {bgra_ffmpeg};
int dstStride[] = {static_cast<int>(4 * w)};
int srcW = w, srcH = h, dstW = w, dstH = h;
AVPixelFormat srcFormat = AV_PIX_FMT_ARGB, dstFormat = AV_PIX_FMT_BGRA;
AVPixelFormat srcFormat = AV_PIX_FMT_RGB24, dstFormat = AV_PIX_FMT_BGRA;
SwsContext *c = sws_getCachedContext(nullptr, srcW, srcH, srcFormat, dstW, dstH, dstFormat, 0, nullptr, nullptr, nullptr);
t1 = high_resolution_clock::now();
sws_scale(c, srcSlice, srcStride, srcSliceY, srcSliceH, dst, dstStride);
t2 = high_resolution_clock::now();
duration = duration_cast<microseconds>( t2 - t1 ).count();
cout << "FFmpeg (" << (argb_same_as_bgra(argb, bgra_ffmpeg, l) ? "success" : "failure")
cout << "FFmpeg (" << (rgb_same_as_bgra(rgb, bgra_ffmpeg, l) ? "success" : "failure")
<< ") took: " << duration << " usec" << endl;
#ifdef USE_OPENCV
{
Expand All @@ -145,28 +134,7 @@ int main(int argc, char *argv[])
free(bgra_ffmpeg);
#endif

// ARGB => BGRA with a function
unsigned char *bgra_function = nullptr;
bgra_function = reinterpret_cast<unsigned char *>(malloc(l * sizeof(unsigned char)));
t1 = high_resolution_clock::now();
copy_strided(argb + 3, argb + l, bgra_function, 4);
copy_strided(argb + 2, argb + l, bgra_function + 1, 4);
copy_strided(argb + 1, argb + l, bgra_function + 2, 4);
copy_strided(argb, argb + l, bgra_function + 3, 4);
t2 = high_resolution_clock::now();
duration = duration_cast<microseconds>( t2 - t1 ).count();
cout << "Function (" << (argb_same_as_bgra(argb, bgra_function, l) ? "success" : "failure")
<< ") took: " << duration << " usec" << endl;
free(bgra_function);
#ifdef USE_OPENCV
{
cv::Mat _bgra(h, w, CV_8UC4, bgra_function), bgr;
cv::cvtColor(_bgra, bgr, cv::COLOR_BGRA2BGR);
cv::imwrite("bgra_function.png", bgr);
}
#endif

// free all memory
free(argb);
free(rgb);
return EXIT_SUCCESS;
}

0 comments on commit fcd8cc4

Please sign in to comment.