Separate Out Backend Options into Individual Structs #6895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a decent amount of code that was just moved and not majorly rewritten. This unfortunately couldn't really be captured well in a move commit without undue effort on my part. |
cwfitzgerald
force-pushed
the
cw/per-backend-configurations
branch
4 times, most recently
from
5dc796b to
96815d2
Compare
Wumpf
requested changes
Jan 11, 2025
There was a problem hiding this comment.
I've been recently dealing with a lot of config things in egui & Rerun and as such I deeply appreciate this refactor. Rather kinda embarrassing I didn't bring it up myself!
But now I'd really really would want to go the extra step to make it even better & consistent, see comments. Also happy to take over
|
Appreciate you caring so much about the little api details, very much appreciate it! |
cwfitzgerald
force-pushed
the
cw/per-backend-configurations
branch
from
96815d2 to
d24ddba
Compare
Wumpf
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Part of the work on #4589
Description
This better organizes the backend options to allow us to add more options without the users needing to explicitly think about it
Testing
Clappy
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.