Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linkwarden to version 2.9.3 and run as root #2094

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

al-lac
Copy link
Contributor

@al-lac al-lac commented Jan 21, 2025

Tested update on Umbrel Home and fresh install on Raspberry Pi 5.

I noticed some bugs like Linkwarden not being able to create snapshots of websites. This is due to the fact that official support for non-root is still missing.
There is already a PR open for non-root support: linkwarden/linkwarden#779

Also changed the database url as I have seem some errors in the logs. Changing it to the full name seems to fix it.

Would run it as root for the time being if that is ok @nmfretz

@al-lac al-lac changed the title Linkwarden 2 9 3 Update Linkwarden to version 2.9.3 Jan 21, 2025
@al-lac al-lac changed the title Update Linkwarden to version 2.9.3 Update Linkwarden to version 2.9.3 and run as root Jan 21, 2025
Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ linkwarden/docker-compose.yml Potentially using unsafe user in service "postgres":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ linkwarden/docker-compose.yml Potentially using unsafe user in service "app":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Jan 22, 2025

Excellent update @al-lac. Great find and fixes re the non-root user issue and postgres url.

Tested and working great.

Under our current apps framework we can run as root if necessary so as to not unnecessarily hamper an apps functionality.

Going from non-root to root user doesn't require us to handle any permissions issues luckily. When non-root support is live we'll need to handle permissions for users updating but not for fresh installs.

@nmfretz nmfretz merged commit ecd5a3d into getumbrel:master Jan 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants