-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(errors): Add migration adding features column #6723
Open
cmanallen
wants to merge
4
commits into
master
Choose a base branch
from
cmanallen/errors-features-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has a migration; here is the generated SQL for -- start migrations
-- forward migration events : 0025_add_features_column
Local op: ALTER TABLE errors_local ADD COLUMN IF NOT EXISTS features Nested(key String, value String) AFTER _tags_hash_map;
Local op: ALTER TABLE errors_local ADD COLUMN IF NOT EXISTS _features_hash_map Array(UInt64) MATERIALIZED arrayMap((k, v) -> cityHash64(concat(replaceRegexpAll(k, '(\\=|\\\\)', '\\\\\\1'), '=', v)), features.key, features.value) AFTER features.value;
Distributed op: ALTER TABLE errors_dist ADD COLUMN IF NOT EXISTS features Nested(key String, value String) AFTER _tags_hash_map;
Distributed op: ALTER TABLE errors_dist ADD COLUMN IF NOT EXISTS _features_hash_map Array(UInt64) MATERIALIZED arrayMap((k, v) -> cityHash64(concat(replaceRegexpAll(k, '(\\=|\\\\)', '\\\\\\1'), '=', v)), features.key, features.value) AFTER features.value;
Distributed op: ALTER TABLE errors_dist_ro ADD COLUMN IF NOT EXISTS features Nested(key String, value String) AFTER _tags_hash_map;
Distributed op: ALTER TABLE errors_dist_ro ADD COLUMN IF NOT EXISTS _features_hash_map Array(UInt64) MATERIALIZED arrayMap((k, v) -> cityHash64(concat(replaceRegexpAll(k, '(\\=|\\\\)', '\\\\\\1'), '=', v)), features.key, features.value) AFTER features.value;
Local op: ALTER TABLE errors_local ADD INDEX IF NOT EXISTS bf_features_hash_map _features_hash_map TYPE bloom_filter GRANULARITY 1;
-- end forward migration events : 0025_add_features_column
-- backward migration events : 0025_add_features_column
Local op: ALTER TABLE errors_local DROP INDEX IF EXISTS bf_features_hash_map;
Distributed op: ALTER TABLE errors_dist_ro DROP COLUMN IF EXISTS _features_hash_map;
Distributed op: ALTER TABLE errors_dist_ro DROP COLUMN IF EXISTS features;
Distributed op: ALTER TABLE errors_dist DROP COLUMN IF EXISTS _features_hash_map;
Distributed op: ALTER TABLE errors_dist DROP COLUMN IF EXISTS features;
Local op: ALTER TABLE errors_local DROP COLUMN IF EXISTS _features_hash_map;
Local op: ALTER TABLE errors_local DROP COLUMN IF EXISTS features;
-- end backward migration events : 0025_add_features_column |
This was referenced Jan 8, 2025
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds migration for the new
features
columns and index. These columns will allow us to search for errors by feature flag.DACI: https://www.notion.so/sentry/DACI-Search-for-Errors-by-Feature-Flag-1288b10e4b5d8014976dcbfbf335bc37?pvs=4#1288b10e4b5d805eb476d313eecae009
Closes: https://github.com/getsentry/team-replay/issues/519