Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nextjs)!: Respect user-provided source map generation settings #14956

Merged
merged 8 commits into from
Jan 10, 2025
Merged

feat(nextjs)!: Respect user-provided source map generation settings #14956

merged 8 commits into from
Jan 10, 2025
+75 −15

Conversation

chargome
Copy link
Member

@chargome chargome commented Jan 9, 2025

  • Enables deleteSourceMapsAfterUpload by default if unset
  • Modifies the webpack sourcemap config if no explicit value is set

closes #14905

@chargome chargome self-assigned this Jan 9, 2025
@chargome chargome marked this pull request as ready for review January 9, 2025 18:48
@chargome chargome requested a review from lforst January 9, 2025 18:48
lforst
lforst approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

packages/nextjs/src/config/webpack.ts Outdated Show resolved Hide resolved
packages/nextjs/src/config/webpack.ts Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
@chargome chargome merged commit 13c6462 into develop Jan 10, 2025
134 checks passed
@chargome chargome deleted the cg/v9-nextjs-respect-sourcemaps branch January 10, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Next.js]: Respect user-provided source map generation settings
2 participants
@chargome @lforst