feat: Event hooks & configuration via GDScript #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
limbonaut
changed the title
limbonaut
commented
Jan 23, 2025
Comment on lines
-138
to
-150
| #ifdef NATIVE_SDK | ||
| internal_sdk = std::make_shared<NativeSDK>(); | ||
| #else | ||
| // Unsupported platform | ||
| sentry::util::print_debug("This is an unsupported platform. Disabling Sentry SDK..."); | ||
| enabled = false; | ||
| #endif | ||
| } | ||
|
|
||
| if (!enabled) { | ||
| sentry::util::print_debug("Sentry SDK is DISABLED! Operations with Sentry SDK will result in no-ops."); | ||
| internal_sdk = std::make_shared<DisabledSDK>(); | ||
| return; |
There was a problem hiding this comment.
FYI this code moved to _intialize()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces configuration via GDScript and adds the user-facing event hooks
before_sendandon_crash, as outlined in https://develop.sentry.dev/sdk/expected-features/#before-send-hook and https://docs.sentry.io/platforms/native/configuration/filtering/.It introduces a new public API class called
SentryConfigurationwhich users can extend in a script, and assign the script file in options to configure the SDK during initialization. However, due to the way scripting is initialized in the Godot Engine, this comes with a trade-off: a slightly later initialization. If a configuration script is assigned, initialization must be delayed untilScriptServeris ready to load and run the user script.Resolves #47
Resolves #48