feat: automatic reconnect #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ios Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bacea1c | 1330.25 ms | 1337.00 ms | 6.75 ms |
| 48be639 | 1301.00 ms | 1321.67 ms | 20.67 ms |
| 4c4f3df | 1292.50 ms | 1333.40 ms | 40.90 ms |
| bf6b3dc | 1272.00 ms | 1310.25 ms | 38.25 ms |
| fc0d02d | 1304.75 ms | 1319.25 ms | 14.50 ms |
| 0590622 | 1313.75 ms | 1321.50 ms | 7.75 ms |
| f8dc4f2 | 1323.00 ms | 1321.00 ms | -2.00 ms |
| 7297039 | 1322.25 ms | 1345.40 ms | 23.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bacea1c | 3.33 MiB | 7.73 MiB | 4.39 MiB |
| 48be639 | 3.33 MiB | 7.73 MiB | 4.39 MiB |
| 4c4f3df | 3.33 MiB | 7.73 MiB | 4.39 MiB |
| bf6b3dc | 3.33 MiB | 7.73 MiB | 4.39 MiB |
| fc0d02d | 3.33 MiB | 7.73 MiB | 4.39 MiB |
| 0590622 | 3.33 MiB | 7.73 MiB | 4.39 MiB |
| f8dc4f2 | 3.33 MiB | 7.73 MiB | 4.39 MiB |
| 7297039 | 3.33 MiB | 7.73 MiB | 4.39 MiB |
android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bacea1c | 389.00 ms | 1761.00 ms | 1372.00 ms |
| 48be639 | 580.80 ms | 2137.00 ms | 1556.20 ms |
| 4c4f3df | 332.33 ms | 1517.33 ms | 1185.00 ms |
| bf6b3dc | 327.67 ms | 1623.40 ms | 1295.73 ms |
| fc0d02d | 321.00 ms | 1656.50 ms | 1335.50 ms |
| 0590622 | 552.67 ms | 2093.67 ms | 1541.00 ms |
| f8dc4f2 | 472.75 ms | 1766.00 ms | 1293.25 ms |
| 7297039 | 421.33 ms | 1663.33 ms | 1242.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bacea1c | 25.32 KiB | 31.80 MiB | 31.77 MiB |
| 48be639 | 25.32 KiB | 31.80 MiB | 31.77 MiB |
| 4c4f3df | 25.32 KiB | 31.80 MiB | 31.77 MiB |
| bf6b3dc | 25.32 KiB | 31.80 MiB | 31.77 MiB |
| fc0d02d | 25.32 KiB | 31.80 MiB | 31.77 MiB |
| 0590622 | 25.32 KiB | 31.80 MiB | 31.77 MiB |
| f8dc4f2 | 25.32 KiB | 31.80 MiB | 31.77 MiB |
| 7297039 | 25.32 KiB | 31.80 MiB | 31.77 MiB |
vaind
force-pushed
the
feat/automatic-reconnect
branch
from
dfe668e to
f0b6f4a
Compare
vaind
force-pushed
the
feat/automatic-reconnect
branch
from
981bfb0 to
169ea17
Compare
vaind
commented
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android builds tend to get disconnected on getLog() - see the issue appium/java-client#2088 (comment)
This PR adds a reconnection logic so when an error ocurs, we just go ahead and start another appium client.