Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ng-annotate with babel plugin #1863

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

44px
Copy link
Contributor

@44px 44px commented Jul 2, 2017

ng-annotate is not maintained anymore. I replaced ng-annotate-loader with recommended babel-plugin-angularjs-annotate

@44px 44px mentioned this pull request Jul 2, 2017
@arikfr
Copy link
Member

arikfr commented Jul 4, 2017

Brilliant. Thanks!

I want to cut a release soon, so to be on the safe side, I will merge this right after.

@44px
Copy link
Contributor Author

44px commented Jul 7, 2017

Ok :)

@arikfr arikfr added this to the v3 milestone Aug 6, 2017
@arikfr arikfr merged commit 5b54a77 into getredash:master Aug 16, 2017
@arikfr
Copy link
Member

arikfr commented Aug 16, 2017

Thanks!

@44px 44px deleted the ng-annotate-deprecation branch August 16, 2017 13:25
seenivasanp added a commit to seenivasanp/redash that referenced this pull request Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants