Update Ingress Configuration and Documentation for LAGO_DOMAIN Path-Based Routing #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen LAGO_DOMAIN is unse
- Refactor documentation to reflect new path-based routing setup using LAGO_DOMAIN. - Remove outdated references to configuration-snippet and allow-snippet-annotations. - Add instructions for separate frontend and API ingress configurations. - Emphasize importance of /api/ prefix for API paths to avoid routing conflicts. - Provide clear guidance for users with NGINX and non-NGINX ingress controllers.
electrosenpai
changed the title
jdenquin
reviewed
Nov 15, 2024
| @@ -82,9 +82,17 @@ spec: | |||
| {{- $pdfHost := printf "%s-pdf-svc.%s" .Release.Name .Release.Namespace}} | |||
| value: {{ printf "http://%s:%v" $pdfHost .Values.pdf.service.port | quote }} | |||
| - name: LAGO_API_URL | |||
| value: {{ required "apiUrl value is required" .Values.apiUrl | quote }} | |||
| value: {{- if .Values.LAGO_DOMAIN }} | |||
There was a problem hiding this comment.
we should not use those env var anymore if LAGO_DOMAIN is present
| @@ -24,11 +24,19 @@ spec: | |||
| containers: | |||
| - env: | |||
| - name: API_URL | |||
| value: {{ .Values.apiUrl | quote }} | |||
| value: {{- if .Values.LAGO_DOMAIN }} | |||
There was a problem hiding this comment.
this is already managed by FE : getlago/lago-front@f74e6e5
We just need to add the LAGO_DOMAIN env var here!
| # apiUrl: mydomain.dev | ||
| # frontUrl: mydomain.dev | ||
|
|
||
| # By setting the LAGO_DOMAIN variable, your application will be available directly on the specified domain. | ||
| # For example, if LAGO_DOMAIN is set to getmydomain.dev, your GetLago instance will be accessible at https://getmydomain.dev, | ||
| # and your API at https://getmydomain.dev/api/api/v1. Note that adding this variable changes the domain structure: |
There was a problem hiding this comment.
I just think about it, but would be awesome if we can manage to not use /api/api, do you think its possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Update Ingress Configuration and Documentation for LAGO_DOMAIN Path-Based Routing
Description:
This PR updates both the Ingress configurations and documentation to implement a path-based routing setup with
LAGO_DOMAIN. Key changes include:/api/prefix./api/prefix before requests reach the backend./api/prefix to prevent routing conflicts with frontend paths.