Feat manual payments controller #3045
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context This PR introduces a new endpoint to list all payments. Additionally, it adds the ability to filter payments by a specific invoice_id, allowing users to narrow down the results to payments associated with a particular invoice. This enhancement improves the flexibility and usability of the payments listing functionality. ## Description **Added Endpoint:** - Created an endpoint to list all payments. - Filter by invoice_id: - Added functionality to filter payments based on the provided invoice_id. - Included a validation step to ensure the invoice_id is in the correct UUID format before executing the query. **Query Updates:** - Refactored PaymentsQuery to handle dynamic filtering by invoice_id. - Ensured that the query properly joins related tables, such as invoices and payment_requests, to support filtering.
…lago-api into feat-manual-payments-controller # Conflicts: # spec/requests/api/v1/payments_controller_spec.rb
ivannovosad
force-pushed
the
feat-manual-payments-controller
branch
from
333db63 to
e4efd7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap Task
👉 https://getlago.canny.io/feature-requests/p/log-partial-payments
Context
This PR introduces a new endpoint to list all payments. Additionally, it adds the ability to filter payments by a specific invoice_id, allowing users to narrow down the results to payments associated with a particular invoice. This enhancement improves the flexibility and usability of the payments listing functionality.
It also adds
createandshowactions in the PaymentsController.Description
Added Endpoint:
Query Updates: