misc(PaymentRequest): Apply payment idempotency refactor #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
refact-payment-request
branch
8 times, most recently
from
0117994 to
66411fe
Compare
rsempe
reviewed
Dec 23, 2024
rsempe
approved these changes
Dec 23, 2024
vincent-pochet
force-pushed
the
refact-payment-request
branch
from
7b8256a to
534b94d
Compare
brunomiguelpinto
approved these changes
Dec 23, 2024
vincent-pochet
force-pushed
the
refact-payment-request
branch
from
534b94d to
ec98ed4
Compare
vincent-pochet
force-pushed
the
refact-payment-request
branch
2 times, most recently
from
e262e32 to
d7f520f
Compare
vincent-pochet
force-pushed
the
refact-payment-request
branch
from
d7f520f to
24369f9
Compare
vincent-pochet
added a commit
that referenced
this pull request
Jan 20, 2025
The issue is related to the merge of #2986 created before the migration but turning the `PENDING_STATUSES` constants to `PROCESSING_STATUSES`
vincent-pochet
added a commit
that referenced
this pull request
Jan 24, 2025
# Context This PR is related to the recent changes introduced by #2962 and #2986 to rely on payment provider idem-potency logic A new `payable_payment_status` was added to the Payment model, but this status is not updated when a webhook is received from a payment provider # Description This PR makes sure that the payment, payment request or all other payment related statuses are updated accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR follow #2962 in the refactor of the payment processing. It applied the logic that was applied to payment for invoices to payment requests
The main goal of this refactor will be to:
Description
This PR applies the following logic for payment processing of payment requests:
PaymentProviders::*::Payments::CreateServiceresponsible only for the payment creation and the error handling (including idempotency). The payment provider payment creation logic will be shared between types of payment and will rely only on the Lago Payment record