Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add geostyler style as a format #416

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat: add geostyler style as a format #416

merged 1 commit into from
Dec 11, 2024

Conversation

olsen232
Copy link
Contributor

@olsen232 olsen232 commented Dec 9, 2024 •
edited
Loading

Adds geostyler as a format, such that

input.geostyler
-s geostyler
-t geostyler
-o output.geostyler

all work.

Tidies up some logic around selecting formats - we don't want to warn the user that no format was specified if they explicitly specified "geostyler"

Removes some duplicated code

  • instantiation of parsers
  • handling of parser errors

Fixes #392

KaiVolland
KaiVolland approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@KaiVolland KaiVolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@KaiVolland KaiVolland merged commit d719d96 into geostyler:main Dec 11, 2024
3 checks passed
@KaiVolland KaiVolland mentioned this pull request Dec 11, 2024
Closed
@jansule
Copy link
Contributor

jansule commented Dec 11, 2024

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiVolland KaiVolland KaiVolland approved these changes

@geographika geographika geographika approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing geostyler as an input parser format
4 participants
@olsen232 @jansule @geographika @KaiVolland