Fix a bug where changes to GWC layers won't be propagated to other pods. #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In vanilla GeoServer, `CatalogConfiguration` is the `TileLayerConfiguration` contributed to the app context to serve `TileLayer`s (`GeoServerTileLayer`) from the GeoServer `Catalog` by means of a `TileLayerCatalog`. This update contributes a different `TileLayerConfiguration` for the same purpose, `GeoServerTileLayerConfiguration`, which is a distributed-event-aware decorator over the actual `CloudCatalogConfiguration` implementation of `TileLayerCatalog`. Since `CloudCatalogConfiguration` is therefore not a Spring bean (to avoid registering it as a delegate to `TileLayerDispatcher`), `TileLayerEvents` need to be relayed from `GeoServerTileLayerConfiguration` to `CloudCatalogConfiguration#onTileLayerEventEvict()`.
groldan
force-pushed
the
bug/gwc_layer_config_propagation
branch
from
4858dac to
f4dfa54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vanilla GeoServer,
CatalogConfigurationis theTileLayerConfigurationcontributed to the app context to serveTileLayers (GeoServerTileLayer) from the GeoServerCatalogby means of aTileLayerCatalog.This update contributes a different
TileLayerConfigurationfor the same purpose,GeoServerTileLayerConfiguration, which is a distributed-event-aware decorator over the actualCloudCatalogConfigurationimplementation ofTileLayerCatalog.Since
CloudCatalogConfigurationis therefore not a Spring bean (to avoid registering it as a delegate toTileLayerDispatcher),TileLayerEventsneed to be relayed fromGeoServerTileLayerConfigurationtoCloudCatalogConfiguration#onTileLayerEventEvict().