-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add --skip-xfail command line argument to prevent xfail to be ran
when in compare mode cf #37
- Loading branch information
1 parent
7d68f79
commit 1643c64
Showing
2 changed files
with
10 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1643c64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see that comparisons with this option are faster. It seems the query is either executed or the creation of it takes the most time.
1643c64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pytest is a two steps process: collection then run.
Collection cannot be reduced by tagging tests given it's basically during the collection that filters are used. AFAIK, the only way to reduce the collection is to reduce the dataset, for example pointing to a single directory:
py.test world/germany/xxxx
, in that point only this target is loaded.As far as I can tell, with this new behaviour, xfail tests are not run at all (I see nothing in my search engine server log), so I'm not sure what can be done more on this direction.
What I usually do is to use a small subset (world/france/nordpasdecalais for example) when I'm actively coding and testing, and run a bigger set when I feel like I'm good.
1643c64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is strange, I have to log searches and investigate this, because the time it takes is not really reduced.
1643c64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because your server is sooooo fast! :)