-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update apt sources, add apt keyring gpg #150
Conversation
I've searched for a solution without using the Any other ideas for that? Thanks for your feedback! (ps. Ok, saving as |
defaults/main.yml
Outdated
kubernetes_apt_ignore_key_error: false | ||
# this one is deprecated and will be deleted with this role | ||
kubernetes_apt_repository: "deb http://apt.kubernetes.io/ kubernetes-xenial {{ kubernetes_apt_release_channel }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could set kubernetes_apt_repository
to the new one.
- name: Be sure deprecated Kubernetes repository is absent. | ||
file: | ||
path: "/etc/apt/sources.list.d/apt_kubernetes_io.list" | ||
state: absent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is a safe way to do that with apt_repository
, please let me know
This is how I currently solve this: https://www.jeffgeerling.com/blog/2022/aptkey-deprecated-debianubuntu-how-fix-ansible |
@geerlingguy yes, I have already seen that. However, The trick seems to be the What about the other stuff with deleting the old source? |
ready for review. |
@rdxmb - I realized my edit to that blog post may have not taken effect; there's a newer/simpler way to do it correctly using Ansible's |
to be honest, I didn't realize the upgrade on your blog post. Maybe I will have a look at |
I opened a similar PR, #153, because I had a miserable time getting |
@geerlingguy Can we get either this PR in or make some progress on #153? The current repos have been deprecated since August 2023 and this role has been broken in its current state since January 31st... |
Merging this for now — I would like to move to |
@geerlingguy Thank you! Can you tag the repo with these changes as well? |
I just realized that this PR did not update the yum repository as well, which should have probably be done at the same time. I can try to work up a PR for that....even one that attempts to use deb822_repository, since it looks like #153 doesn't update the yum repo either |
@rhino5oh - oh haha, that makes sense, and I would gladly merge a PR updating yum/dnf too! |
I've pushed a commit that should hopefully fix yum. |
fix #149
fix #105
see https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#installing-kubeadm-kubelet-and-kubectl