Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: main storage offset value #329

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix: main storage offset value #329

merged 1 commit into from
Dec 20, 2023

Conversation

gballet
Copy link
Owner

@gballet gballet commented Dec 14, 2023

MAIN_STORAGE_OFFSET is specified at $256^{31}$ and it is currently coded at $256 \times 2^{31}$. This PR fixes it to match the spec.

@gballet gballet requested a review from jsign December 14, 2023 18:04
jsign
jsign approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrudolf jrudolf mentioned this pull request Dec 18, 2023
Closed
g11tech
g11tech approved these changes Dec 20, 2023
View reviewed changes
Copy link

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gballet
Copy link
Owner Author

gballet commented Dec 20, 2023

Confirmed to be wrong in all clients following the testnet. Merging.

@gballet gballet merged commit 0191752 into kaustinen-with-shapella Dec 20, 2023
2 of 3 checks passed
gballet added a commit that referenced this pull request May 7, 2024
@gballet
fix: main storage offset value (#329)
e65bca7
gballet added a commit that referenced this pull request May 8, 2024
@gballet
fix: main storage offset value (#329)
f952558
gballet added a commit that referenced this pull request May 8, 2024
@gballet
fix: main storage offset value (#329)
8bf67d9
gballet added a commit that referenced this pull request Dec 5, 2024
@gballet @jsign
trie/{,utils}: ensure master can generate correct genesis for kaustinen7
216ad6f 
This imports the following fixes:

 - update gnark to 1.1.0
 - update go-verkle to 0.2.2
 - fix: main storage offset bug (#329)
 - fix: tree key generation (#401)

co-authored-by: Ignacio Hagopian <[email protected]>
@gballet gballet mentioned this pull request Dec 5, 2024
Merged
gballet added a commit to ethereum/go-ethereum that referenced this pull request Dec 6, 2024
@gballet @jsign
trie/utils: ensure master can generate a correct genesis for kaustine…
08e6bdb 
…n7 (#30856)

This imports the following fixes:

 - update gnark to 1.1.0
 - update go-verkle to 0.2.2
 - fix: main storage offset bug (gballet#329)
 - fix: tree key generation (gballet#401)

---------

Signed-off-by: Guillaume Ballet <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>
sebastianst pushed a commit to ethereum-optimism/op-geth that referenced this pull request Jan 23, 2025
@gballet @jsign @sebastianst
trie/utils: ensure master can generate a correct genesis for kaustine…
d292c3f 
…n7 (#30856)

This imports the following fixes:

 - update gnark to 1.1.0
 - update go-verkle to 0.2.2
 - fix: main storage offset bug (gballet/go-ethereum#329)
 - fix: tree key generation (gballet/go-ethereum#401)

---------

Signed-off-by: Guillaume Ballet <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

@jsign jsign jsign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gballet @jsign @g11tech