review feedback

Signed-off-by: Ignacio Hagopian <[email protected]>

cmd/evm/main.go

@@ -172,25 +172,25 @@ var verkleCommand = &cli.Command{
 		},
 		{
 			Name:    "single-key",
-			Aliases: []string{"V"},
+			Aliases: []string{"vk"},
 			Usage:   "compute the verkle tree key given an address and optional slot number",
 			Action:  t8ntool.VerkleKey,
 		},
 		{
 			Name:    "code-chunk-key",
-			Aliases: []string{"VCK"},
+			Aliases: []string{"vck"},
 			Usage:   "compute the verkle tree key given an address and chunk number",
 			Action:  t8ntool.VerkleCodeChunkKey,
 		},
 		{
 			Name:    "chunkify-code",
-			Aliases: []string{"VCC"},
+			Aliases: []string{"vcc"},
 			Usage:   "chunkify a given bytecode",
 			Action:  t8ntool.VerkleChunkifyCode,
 		},
 		{
 			Name:    "state-root",
-			Aliases: []string{"VR"},
+			Aliases: []string{"vsr"},
 			Usage:   "compute the state-root of a verkle tree for the given alloc",
 			Action:  t8ntool.VerkleRoot,
 			Flags: []cli.Flag{

consensus/beacon/consensus.go

@@ -28,6 +28,7 @@ import (
 	"github.com/ethereum/go-ethereum/core/overlay"
 	"github.com/ethereum/go-ethereum/core/state"
 	"github.com/ethereum/go-ethereum/core/types"
+	"github.com/ethereum/go-ethereum/log"
 	"github.com/ethereum/go-ethereum/params"
 	"github.com/ethereum/go-ethereum/rpc"
 	"github.com/ethereum/go-ethereum/trie"
@@ -365,6 +366,7 @@ func (beacon *Beacon) Finalize(chain consensus.ChainHeaderReader, header *types.
 		// fmt.Println("at block", header.Number, "performing transition?", state.Database().InTransition())
 		parent := chain.GetHeaderByHash(header.ParentHash)
 		if err := overlay.OverlayVerkleTransition(state, parent.Root, chain.Config().OverlayStride); err != nil {
+			log.Error("error performing the transition", "err", err)
 			panic(fmt.Sprintf("error performing the transition: %s", err))
 		}
 	}

core/genesis.go

@@ -161,6 +161,7 @@ func (ga *GenesisAlloc) flush(db ethdb.Database, triedb *trie.Database, blockhas
 	}
 
 	for addr, account := range *ga {
+		// TODO set back to AddBalance after rebase
 		statedb.SetBalance(addr, account.Balance)
 		statedb.SetCode(addr, account.Code)
 		statedb.SetNonce(addr, account.Nonce)