Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove anvil renaming cost #5

Closed
wants to merge 2 commits into from

Conversation

CoolandonRS
Copy link
Contributor

@CoolandonRS CoolandonRS commented Jan 15, 2024

What it says on the tin.
fixes: game-design-driven/Create-Prepare-to-Dye#409

@CoolandonRS
Copy link
Contributor Author

CoolandonRS commented Jan 15, 2024

Do test this, there is a 90% chance it works but it still might not. If it doesn't there are other was to do it that are roughly as trivial as this one

@jasperalani
Copy link
Collaborator

waiting for game-design-driven/Create-Prepare-to-Dye#517 to be accepted then will test this

@jasperalani
Copy link
Collaborator

jasperalani commented Jan 17, 2024

Hey @CoolandonRS would you mind adding comments to the Shenanigans.java class otherwise in the future it might be hard to understand whats going on

@jasperalani jasperalani self-requested a review January 17, 2024 20:52
@CoolandonRS
Copy link
Contributor Author

Yeah I suppose. It's already going to be hard to understand because it is just reflection witchery but I'll add some to try to help out.

The names of variables could be changed to be clearer, but that's much less fun. Will rename as such if it's desired, of course.
@jasperalani
Copy link
Collaborator

I can't get it to work sadly. Did you not test it yourself?

@CoolandonRS
Copy link
Contributor Author

No, I didn't test it since I couldn't get gradle runClient to work and didn't want to debug it at the time. Now that I already have I'll debug it some more and see if I can verify it works/create a new (functioning) solution

@CoolandonRS
Copy link
Contributor Author

CoolandonRS commented Jan 23, 2024

Way weirder then what I originally thought (check the edit history if your curious) but I know the cause of the problem and am now just searching for a solution

@CoolandonRS
Copy link
Contributor Author

Replaced by #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Make it free to rename things in the anvil
2 participants