-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove anvil renaming cost #5
Conversation
Do test this, there is a 90% chance it works but it still might not. If it doesn't there are other was to do it that are roughly as trivial as this one |
waiting for game-design-driven/Create-Prepare-to-Dye#517 to be accepted then will test this |
Hey @CoolandonRS would you mind adding comments to the Shenanigans.java class otherwise in the future it might be hard to understand whats going on |
Yeah I suppose. It's already going to be hard to understand because it is just reflection witchery but I'll add some to try to help out. |
The names of variables could be changed to be clearer, but that's much less fun. Will rename as such if it's desired, of course.
I can't get it to work sadly. Did you not test it yourself? |
No, I didn't test it since I couldn't get |
Way weirder then what I originally thought (check the edit history if your curious) but I know the cause of the problem and am now just searching for a solution |
Replaced by #12 |
What it says on the tin.
fixes: game-design-driven/Create-Prepare-to-Dye#409