Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed a short feedback form at the bottom of the tutorial #988

Merged
merged 9 commits into from
Sep 7, 2018
Merged

Embed a short feedback form at the bottom of the tutorial #988

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
77f4d37
Embed a short feedback form at the bottom of the tutorial
bebatut Aug 27, 2018
be566c3
add discalaimer about type and visibility of feedback
shiltemann Aug 28, 2018
1c4d8fb
change height to account for extra description text added to form
shiltemann Aug 28, 2018
fd21b11
moved disclaimers to forms
shiltemann Aug 28, 2018
d7fd230
change height to account for extra description text added to form
shiltemann Aug 28, 2018
1104548
improve styling, moved hrule to form header image
shiltemann Aug 30, 2018
87d0d81
also prefill tutorial name for extended form
shiltemann Aug 30, 2018
abc568c
phrasing
shiltemann Aug 30, 2018
0b82064
google improved form embedding, undo formatting fixes
shiltemann Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions _layouts/tutorial_hands_on.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,12 +221,16 @@ <h3>{% icon congratulations %} Congratulations on successfully completing this t

<hr>

<p>Please let us know what you thought of this tutorial below! This feedback should be about the training materials themselves only. If tools were not working or missing, please contact the administrators of the Galaxy instance you used. </p>

<p>Please note that your feedback will be anonymous, but <strong>publicly visible</strong> (on this <a href="https://github.com/galaxyproject/training-material/issues/989">GitHub issue</a>).</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this optional, maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a checkbox to the forms to make feedback confidential, in which case it will not be posted to the github issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @shiltemann !


<iframe class="google-form" src="https://docs.google.com/forms/d/e/1FAIpQLSd4VZptFTQ03kHkMz0JyW9b6_S8geU5KjNE_tLM0dixT3ZQmA/viewform?embedded=true&entry.1235803833={{ page.title }} ({{ topic.title }})">Loading...
</iframe>

<blockquote class="feedback">
<h3>{% icon feedback %} Help us improve this content!</h3>
Please take a moment to fill in the Galaxy Training Network
<a href="https://tinyurl.com/GTNfeedback">Feedback Form</a>.
Your feedback helps us improve this tutorial and will be considered
in future revisions.
<h3>{% icon feedback %} To give us even more feedbacks on this content!</h3>
<p>You can take a moment to fill in the extended <a href="https://tinyurl.com/GTNfeedback">Feedback Form</a>.</p>
</blockquote>
</section>
</div>
Expand Down
6 changes: 6 additions & 0 deletions assets/css/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,12 @@ footer {
.fold-unfold {
margin-left: $tutorial-box-spacing;
}

.google-form {
width: 100%;
height: 1200px;
border: 0;
}
}

.contributors {
Expand Down