-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new tutorial for deciphering viral populations using SNV and baculovirus isolates (Variant analysis) #5700
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! Welcome @wennj!
I have added a few batch of comments, if you agree with them you can accept them from inside the github interface.
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Björn Grüning <[email protected]>
I just did something wrong when trying to solve this comment plus adding an additional change.
@bgruening Many thanks for the suggestions and feedback. I have addressed all comments. As this is my first tutorial and my first pull request, I hope everything is checked correctly. |
Thanks a lot! Let's wait for some experts in this area to get some content feedback. Can you please add the |
I would like to check that first with my administration. Can this also be done at a later stage? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work @wennj !
Those awk expressions are rather intimidating for beginners I guess, but also elegant compared to multi-step solutions with other tools.
Can be interesting to teach them :-)
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.bib
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/workflows/main_workflow.ga
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
> | ||
> 1. {% tool [Trim Galore!](toolshed.g2.bx.psu.edu/repos/bgruening/trim_galore/trim_galore/0.6.7+galaxy0) %} with the following parameters: | ||
> - *"Is this library paired- or single-end?"*: `Paired Collection` | ||
> - {% icon param-collection %} *"Select a paired collection"*: `output` (output of **Download and Extract Reads in FASTAQ format from NCBI SRA** {% icon tool %}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> - {% icon param-collection %} *"Select a paired collection"*: `output` (output of **Download and Extract Reads in FASTAQ format from NCBI SRA** {% icon tool %}) | |
> - {% icon param-collection %} *"Select a paired collection"*: `Paired-end data (fastq-dump)` (output of **Download and Extract Reads in FASTAQ format from NCBI SRA** {% icon tool %}) |
In general, in the GTN we are not using a tool's output name (as defined in the tool wrapper), but the user facing label of the generated dataset if that is a nice one, or a label-like description of the dataset. Take a look at https://training.galaxyproject.org/training-material/topics/evolution/tutorials/mtb_transmission/tutorial.html as an example, then change most of your hands-on boxes accordingly.
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
> > <question-title>Mainly two nucleotides only in vairable SNV positions?</question-title> | ||
> > Think about an option how the occurance of one, two, three or four nucleotides per SNV position can be analyzed. | ||
> {: .comment} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you improve the wording of this question? It's not easy to understand.
topics/variant-analysis/tutorials/baculovirus-isolate-variation/tutorial.md
Outdated
Show resolved
Hide resolved
SNV: Single nucleotide variant | ||
SRA: Sequence Read Archive | ||
key_points: | ||
- Baculovirus populations are heterogeneous and show genetic variability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are mostly talking about isolates, but sometimes also about populations or samples.
I realize the terminology around the concept may be the source of endless debates, but maybe you could reserve a small paragraph in the introduction for explaining what an isolate is in the context here and why it can be a mix of things.
Co-authored-by: Björn Grüning <[email protected]>
…n/tutorial.md Co-authored-by: Wolfgang Maier <[email protected]>
…n/tutorial.md Co-authored-by: Wolfgang Maier <[email protected]>
…n/tutorial.md Co-authored-by: Wolfgang Maier <[email protected]>
…n/tutorial.md Co-authored-by: Wolfgang Maier <[email protected]>
…n/tutorial.md Co-authored-by: Wolfgang Maier <[email protected]>
Dear GTN Team,
I am a new contributor and have created a tutorial for analysing virus populations using SNV (and using the example of large dsDNA viruses). The workflow is based on published results and follows a scientific approach. I have followed the GTN instructions as closely as possible (and as I understand them). Please excuse any mistakes in using Github. The tutorial has also been reviewed by a student.
Key changes:
Checked:
Help:
TODO:
Best,
JTW