Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource params #81

Draft
wants to merge 6 commits into
base: anvil
Choose a base branch
from

Conversation

ksuderman
Copy link
Collaborator

Adds the configuration needed for users to be able to configure resource parameters (cores, memory, and runtime) for individual tools. To make use of these changes will also require a PR to Leo to pass the hardware values to the chart. The current values passed by Leo are not available in the chart and only seem to be used by the Kubernetes runner.

Closes #79

@ksuderman ksuderman added the feature Auto-update minor version label Apr 16, 2024
@ksuderman ksuderman requested review from afgane and nuwang April 16, 2024 16:35
Copy link
Member

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, other than the issue with the dependency.

galaxykubeman/Chart.yaml Outdated Show resolved Hide resolved
galaxykubeman/values.yaml Outdated Show resolved Hide resolved
ksuderman and others added 2 commits April 16, 2024 15:22
Use the shortened URL for the TPV databaes.

Co-authored-by: Nuwan Goonasekera <[email protected]>
@afgane
Copy link
Collaborator

afgane commented Apr 16, 2024

@nuwang, given you seemingly remember, could you please add a comment about why Galaxy is installed via a job? I recall us working on that but could not remember why we had to do it that way so trying to avoid that in the future.

@nuwang
Copy link
Member

nuwang commented Apr 16, 2024

Sure. I could have sworn we added a whole bunch of comments about it, but nothing seems to be there (or it never happened in the first place).

@nuwang
Copy link
Member

nuwang commented Apr 16, 2024

Just a PR description, no comments: #57
Will fix.

@nuwang
Copy link
Member

nuwang commented Apr 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Auto-update minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow resource configuration
3 participants