Add import endpoint for history contents from library #18960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Oct 9, 2024
| return rval | ||
|
|
||
| for ld in traverse(folder): | ||
| hda = ld.library_dataset_dataset_association.to_history_dataset_association(history, add_to_history=True) |
There was a problem hiding this comment.
You're committing once per added item here, that's what I meant when I said batch import could use some improvements.
mvdbeek
reviewed
Oct 9, 2024
| rval.extend(traverse(subfolder)) | ||
| for ld in folder.datasets: | ||
| if not admin: | ||
| can_access = security_agent.can_access_dataset( |
There was a problem hiding this comment.
There's a can_access_datasets function that should be more efficient.
There was a problem hiding this comment.
@mvdbeek This function only returns True or False and what will happen if we have a mixed library folder that some have access to and some don't?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a new API endpoint (
/api/histories/{history_id}/contents/import) to batch create items in a specified history from library datasets and folders. This enhances flexibility for users by allowing multiple datasets to be imported simultaneously, improving efficiency when updating their histories.The changes include new payload definitions and refined service methods to support the import process.
How to test the changes?
(Select all options that apply)
License