Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix toolshed sessionless access to a few APIs broken with.. #18680

Conversation

jmchilton
Copy link
Member

... 12b34ff

Likely the source the bootstrap script being broken as reported by @davelopez here #18538.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member

mvdbeek commented Aug 15, 2024

Still draft @jmchilton ?

@jmchilton jmchilton force-pushed the restore_tool_shed_sessionless_apis branch from f22b999 to 7f4bb4f Compare August 20, 2024 18:53
@jmchilton jmchilton changed the title Fix toolshed sessionless access to a few APIs broken with.. [23.1] Fix toolshed sessionless access to a few APIs broken with.. Aug 20, 2024
@jmchilton
Copy link
Member Author

I've retargeted this at 23.1 since that is where the tool shed is at. The tool shed was non-responsive the night I opened this PR and I couldn't figure out which version it was at.

@jmchilton jmchilton changed the base branch from dev to release_23.1 August 20, 2024 18:55
@mvdbeek
Copy link
Member

mvdbeek commented Aug 20, 2024

I don't think we're going to update the TS before we move to 2.0, can we just do dev ?

@jmchilton
Copy link
Member Author

jmchilton commented Aug 20, 2024

This fix is only for the old tool shed so I can start testing the new tool shed locally again 😆. This is not code that would be in use with the new tool shed.

Update: Just to clarify... if you're going to upgrade the tool shed... I think it is more than fine to just skip this. This is dead code. If we're not going to do a full tool shed upgrade anytime soon - this fix would be really helpful for bootstrapping and testing the new tool shed... but I am not doing the admin work so a simple no is fine. It will hold back development on the new tool shed in the interim I think - which is again fine I think - it doesn't have to be priority either way.

@jmchilton jmchilton marked this pull request as ready for review August 21, 2024 19:44
@github-actions github-actions bot added this to the 23.2 milestone Aug 21, 2024
@mvdbeek mvdbeek merged commit d474492 into galaxyproject:release_23.1 Sep 27, 2024
49 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants