[24.0] Set minimum weasyprint version #18606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not pinning transitive conditional dependencies, and a new pydyf version, which is a dependency of weasyprint, had a new release with a breaking change, see (Kozea/WeasyPrint#2200). Newer releases of weasyprint have introduced max version pins, so I think we're ok with just setting a minimum version here.
|
Arg, of course, that's why the tests failed. The fixed version is only available for python >= 3.9 ... . Guess we need some python version-specific logic here to pin the version of pydyf. |
nsoranzo
reviewed
Jul 28, 2024
There was a problem hiding this comment.
This fixes the API and Selenium tests, which run on Python 3.8, but I think this is still an issue for >=3.9. We will need to revisit this once a new Weasyprint release is out that includes Kozea/WeasyPrint@c345629 .
|
That commit just adds the upper bound, to make 3.9 work all that's needed is a recent version of weasyprint. |
I don't think this works with our custom parsing, but worth a try. Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Jul 28, 2024
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not pinning transitive conditional dependencies, and a new pydyf version, which is a dependency of weasyprint, had a new release with a breaking change, see (Kozea/WeasyPrint#2200).
Newer releases of weasyprint have introduced max version pins, so I think we're ok with just setting a minimum version here.
How to test the changes?
(Select all options that apply)
License