Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve update user API payload schema #18602

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Improve update user API payload schema #18602

merged 1 commit into from
Jul 26, 2024

Conversation

davelopez
Copy link
Contributor

Part of #18532

Before After
image image

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes area/API labels Jul 26, 2024
@github-actions github-actions bot added this to the 24.2 milestone Jul 26, 2024
@davelopez davelopez force-pushed the improve_update_user_api_schema branch from dbd1f07 to e4a7245 Compare July 26, 2024 12:30
@davelopez davelopez marked this pull request as draft July 26, 2024 14:41
@davelopez davelopez force-pushed the improve_update_user_api_schema branch from e4a7245 to 3f26f69 Compare July 26, 2024 14:54
@davelopez davelopez marked this pull request as ready for review July 26, 2024 14:55
@davelopez
Copy link
Contributor Author

Test failures are unrelated

bgruening
bgruening approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davelopez!

@bgruening bgruening merged commit 543ad8b into galaxyproject:dev Jul 26, 2024
50 of 55 checks passed
@davelopez davelopez deleted the improve_update_user_api_schema branch July 26, 2024 17:38
@davelopez davelopez mentioned this pull request Aug 9, 2024
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
area/API kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@davelopez @bgruening