-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable verbatimModuleSyntax, fix jest usage #18595
Conversation
7c29c77
to
de73c64
Compare
Hmmm... some selenium tests in |
de73c64
to
450de78
Compare
…er -- todo, untangle this and avoid the side effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This PR was merged without a "kind/" label, please correct. |
@davelopez Thanks -- the problem here was actually some code that imported types from the api schema, which in turn executed the initial configuration of the fetcher. I figured with your work on openapi-fetch we should just push a resolution for that down the road and make |
Left this setting hanging around longer than I needed to, but in the vue3 branch we have to resolve it. Following the import fixes in #18589, this can simply be overriden for jest and enabled otherwise -- module syntax is still validated when one builds/works on the client, we can ignore it for jest for simplicity.
Also bumped a few minor jest-related dependencies while digging around.
How to test the changes?
(Select all options that apply)
License