Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable verbatimModuleSyntax, fix jest usage #18595

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Jul 24, 2024

Left this setting hanging around longer than I needed to, but in the vue3 branch we have to resolve it. Following the import fixes in #18589, this can simply be overriden for jest and enabled otherwise -- module syntax is still validated when one builds/works on the client, we can ignore it for jest for simplicity.

Also bumped a few minor jest-related dependencies while digging around.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon changed the title Enable verbatimModuleSyntax, fix jest usage and Enable verbatimModuleSyntax, fix jest usage Jul 24, 2024
@dannon dannon marked this pull request as ready for review July 24, 2024 20:31
@github-actions github-actions bot added this to the 24.2 milestone Jul 24, 2024
@dannon dannon force-pushed the verbatimModuleSyntax branch 2 times, most recently from 7c29c77 to de73c64 Compare July 31, 2024 02:53
@davelopez
Copy link
Contributor

Hmmm... some selenium tests in test_stock_tours.py seem to fail consistently... 🤔

@dannon dannon force-pushed the verbatimModuleSyntax branch from de73c64 to 450de78 Compare August 5, 2024 19:18
…er -- todo, untangle this and avoid the side effect.
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davelopez davelopez merged commit db9ff9e into galaxyproject:dev Aug 6, 2024
30 checks passed
Copy link

github-actions bot commented Aug 6, 2024

This PR was merged without a "kind/" label, please correct.

@dannon
Copy link
Member Author

dannon commented Aug 6, 2024

@davelopez Thanks -- the problem here was actually some code that imported types from the api schema, which in turn executed the initial configuration of the fetcher. I figured with your work on openapi-fetch we should just push a resolution for that down the road and make getRoot return the default when used in a context that has no document (i.e. -- the search worker) as a quick fix.

@itisAliRH itisAliRH deleted the verbatimModuleSyntax branch September 18, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants