Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openapi-typescript dependency to version 6.7.6 #18519

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Jul 9, 2024

xref #18093 (comment)

This is not the latest version, but version 7.0.0+ introduces breaking changes that we need to investigate in more detail.
Updating to this version fixes an issue with #18093 (comment) but also changes some of the generated API types to what looks like more accurate ones. So I had to fix some of the issues that popped up when building the client, including fixing the return type (or rather non-return type) of the copy collection API endpoint.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Jul 9, 2024
@github-actions github-actions bot added this to the 24.2 milestone Jul 9, 2024
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like solid improvements, thank @davelopez!

@mvdbeek mvdbeek merged commit 5acd5c1 into galaxyproject:dev Jul 10, 2024
56 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Jul 10, 2024

Also curious to see what 7.0 does, if you want to open a PR we can look at whether changes are reasonable.

@davelopez davelopez deleted the update_openapi_typescript_6.7.6 branch July 10, 2024 13:58
@davelopez
Copy link
Contributor Author

Sure! I will open a PR, I think it was something with the transforms, but I didn't investigate further it may very well be that we don't need those anymore or require some adaptation 👍

@davelopez
Copy link
Contributor Author

Also curious to see what 7.0 does, if you want to open a PR we can look at whether changes are reasonable.

I opened a follow up in #18532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/client kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants