Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Separate ConnectedValue from RuntimeValue #17678

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 12, 2024

Writing tests turned out to be trickier than expected since gxformat2 injects RuntimeValues into the state ...

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton
Copy link
Member

A connected value is a value set at runtime... so this seems silly to me but I'm fine with it if you think it is more readable.

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 12, 2024

I thought ConnectedValue is what we inject for values that are connected at definition time, as opposed to runtime values which are not and must be set by the user. Or are your and my definition compatible and I didn't understand something ?

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 12, 2024

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 12, 2024

ok, I see your point, it's literally what you wrote, I was mixing up runtime with "submission time".

@mvdbeek mvdbeek force-pushed the no_runtime_value_connected_value_mixup branch from f18c43c to b1a8317 Compare March 12, 2024 18:13
@mvdbeek mvdbeek force-pushed the no_runtime_value_connected_value_mixup branch from b1a8317 to 13a691c Compare March 12, 2024 18:23
@mvdbeek mvdbeek marked this pull request as ready for review March 13, 2024 08:47
@github-actions github-actions bot added this to the 23.2 milestone Mar 13, 2024
@mvdbeek mvdbeek merged commit 27feb74 into galaxyproject:release_23.2 Mar 13, 2024
39 of 46 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo deleted the no_runtime_value_connected_value_mixup branch March 13, 2024 09:39
mvdbeek added a commit to Delphine-L/iwc that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants