[23.2] Fix tool panel workflow and favorites button bugs #17634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen if the user has Galaxy open on 2 windows, and they changed the panel view, it will show up on one, and would keep loading on the other since the panel isn't populated (panel string is stored in `localStorage` and panel views in the pinia store; both don't get updated simultaneously.
... as this also fixes the "could not find icon" error.
ahmedhamidawan
changed the title
If you reloaded `ToolsList` with no filters, instead of showing the entire toolset, it would show no results. This was because `itemsLoaded` needed to be a reactive computed value instead of a ref.
Tools with `/` in their id couldn't be unfavorited because the URI wouldn't be encoded
|
Works well, thank you! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload button was visible in the workflow editor tool panel. Fixes other bugs as well such as Favorites button not rendering in the panel, as well as changing panel view not updating the pinia store if Galaxy is open in multiple windows.
Fixes #17602
Fixes #17150
(although can't seem to reproduce part 2 of that:
Fixes #17519
How to test the changes?
(Select all options that apply)
License