Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require name for workflows on save, set default to Unnamed Workflow #17038

Merged

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Nov 15, 2023

Also, use Toast instead of modal for empty name, as well as Toast.success on newly created workflow
Fixes #16998
Fixes #16997

Before
wf_editor_req_name_before.mp4
After
wf_editor_req_name_after.mp4

To Do:
- Also require name for Workflow update method (PUT /api/workflows/{id}) like we do for the create method (PUT /api/workflow/create) already.
Done ✅

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Also, use `Toast` instead of modal for empty name, as well as
`Toast.success` on newly created workflow
This is handled at the frontend in the editor to prevent this,
but still add additional checks in backend
@ahmedhamidawan ahmedhamidawan force-pushed the workflow_editor_require_name branch from 646613a to ea8cffd Compare November 16, 2023 18:39
Copy link
Member

@martenson martenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement. Thanks @ahmedhamidawan !

@martenson martenson merged commit 8806d60 into galaxyproject:dev Nov 17, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

replace validation modal during workflow creation workflows: require name or don't
3 participants