Skip to content

Commit

Permalink
Merge pull request #18634 from mvdbeek/import_relabel_from_file_error…
Browse files Browse the repository at this point in the history
…_message

[24.1] Improve relabel identifiers message when number of columns is not 2
  • Loading branch information
mvdbeek authored Aug 1, 2024
2 parents 745913d + 2ae80c9 commit fba5024
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion lib/galaxy/tools/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3812,8 +3812,14 @@ def add_copied_value_to_new_elements(new_label, dce_object):
if how_type == "tabular":
# We have a tabular file, where the first column is an existing element identifier,
# and the second column is the new element identifier.
new_labels_dict = {}
source_new_label = (line.strip().split("\t") for line in new_labels)
new_labels_dict = dict(source_new_label)
for i, label_pair in enumerate(source_new_label):
if not len(label_pair) == 2:
raise exceptions.MessageException(
f"Relabel mapping file line {i + 1} contains {len(label_pair)} columns, but 2 are required"
)
new_labels_dict[label_pair[0]] = label_pair[1]
for dce in hdca.collection.elements:
dce_object = dce.element_object
element_identifier = dce.element_identifier
Expand Down

0 comments on commit fba5024

Please sign in to comment.