Rename groups section in visualization xml to tracks while allowing b…

…ackward compatibility
galaxyproject · Sep 13, 2024 · c49b58d · c49b58d
1 parent bd54d46
commit c49b58d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/client/src/mvc/visualization/chart/views/editor.js b/client/src/mvc/visualization/chart/views/editor.js
@@ -36,7 +36,7 @@ export default Backbone.View.extend({
                 )
                 .append(new Settings(this.app).$el),
         });
-        if (this.chart.plugin.groups) {
+        if (this.chart.plugin.tracks) {
             this.tabs.add({
                 id: "groups",
                 icon: "fa-database",

diff --git a/client/src/mvc/visualization/chart/views/groups.js b/client/src/mvc/visualization/chart/views/groups.js
@@ -25,7 +25,7 @@ var GroupView = Backbone.View.extend({
     },
     render: function () {
         var self = this;
-        var inputs = Utils.clone(this.chart.plugin.groups) || [];
+        var inputs = Utils.clone(this.chart.plugin.tracks) || [];
         var dataset_id = this.chart.get("dataset_id");
         if (dataset_id) {
             this.chart.state("wait", "Loading metadata...");
@@ -127,7 +127,7 @@ export default Backbone.View.extend({
         });
     },
     render: function () {
-        if (_.size(this.chart.plugin.groups) > 0) {
+        if (_.size(this.chart.plugin.tracks) > 0) {
             this.repeat.$el.show();
         } else {
             this.repeat.$el.hide();

diff --git a/lib/galaxy/visualization/plugins/config_parser.py b/lib/galaxy/visualization/plugins/config_parser.py
@@ -151,9 +151,9 @@ def parse_visualization(self, xml_tree):
         if (specs_section := xml_tree.find("specs")) is not None:
             returned["specs"] = DictParser(specs_section)
 
-        # load group specifiers
-        if (groups_section := xml_tree.find("groups")) is not None:
-            returned["groups"] = ListParser(groups_section)
+        # load tracks specifiers (allow 'groups' section for backward compatibility)
+        if (tracks_section := xml_tree.find("tracks") or xml_tree.find("groups")) is not None:
+            returned["tracks"] = ListParser(tracks_section)
 
         # load settings specifiers
         if (settings_section := xml_tree.find("settings")) is not None:

diff --git a/lib/galaxy/visualization/plugins/plugin.py b/lib/galaxy/visualization/plugins/plugin.py
@@ -125,8 +125,8 @@ def to_dict(self):
             "embeddable": self.config.get("embeddable"),
             "entry_point": self.config.get("entry_point"),
             "settings": self.config.get("settings"),
-            "groups": self.config.get("groups"),
             "specs": self.config.get("specs"),
+            "tracks": self.config.get("tracks"),
             "href": self._get_url(),
         }