Skip to content

Commit

Permalink
Fix condition to include null object store IDs
Browse files Browse the repository at this point in the history
This fixes the unit tests because when the dataset.object_store_id was null, the condition was also evaluated to null.
  • Loading branch information
davelopez committed Jan 13, 2025
1 parent 50ebdcc commit c42245c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/galaxy/model/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ def stderr(self, stderr):
LEFT OUTER JOIN library_dataset_dataset_association ON dataset.id = library_dataset_dataset_association.dataset_id
WHERE dataset.id IN (SELECT dataset_id FROM per_hist_hdas)
AND library_dataset_dataset_association.id IS NULL
AND dataset.object_store_id NOT LIKE 'user_objects://%'
AND (dataset.object_store_id NOT LIKE 'user_objects://%' OR dataset.object_store_id IS NULL)
{and_dataset_condition}
"""

Expand Down

0 comments on commit c42245c

Please sign in to comment.