Apply Nicola's suggestions

galaxyproject · Nov 14, 2023 · 6cde33f · 6cde33f
1 parent 6f1b60a
commit 6cde33f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/galaxy/model/__init__.py b/lib/galaxy/model/__init__.py
@@ -1635,9 +1635,9 @@ def all_entry_points_configured(self):
             all_configured = ep.configured and all_configured
         return all_configured
 
-    def set_state(self, state):
+    def set_state(self, state: JobState) -> bool:
         """
-        Save state history. Returns True if stat has changed, else False
+        Save state history. Returns True if state has changed, else False.
         """
         if self.state == state:
             # Nothing changed, no action needed

diff --git a/lib/galaxy/workflow/scheduling_manager.py b/lib/galaxy/workflow/scheduling_manager.py
@@ -333,7 +333,7 @@ def __attempt_schedule(self, invocation_id, workflow_scheduler):
             try:
                 if workflow_invocation.state == workflow_invocation.states.CANCELLING:
                     workflow_invocation.cancel_invocation_steps()
-                    workflow_invocation.state = workflow_invocation.states.CANCELLED
+                    workflow_invocation.mark_cancelled()
                     session.commit()
                     return False