Proper subclassing of ModelManager generic class

galaxyproject · Jan 22, 2025 · 2dac49b · 2dac49b
1 parent db98387
commit 2dac49b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/galaxy/managers/hdcas.py b/lib/galaxy/managers/hdcas.py
@@ -59,7 +59,7 @@ def set_collection_attributes(dataset_element, *payload):
 
 # TODO: to DatasetCollectionInstanceManager
 class HDCAManager(
-    base.ModelManager,
+    base.ModelManager[model.HistoryDatasetCollectionAssociation],
     secured.AccessibleManagerMixin,
     secured.OwnableManagerMixin,
     deletable.PurgableManagerMixin,

diff --git a/lib/galaxy/managers/tools.py b/lib/galaxy/managers/tools.py
@@ -30,7 +30,7 @@
     from galaxy.managers.base import OrmFilterParsersType
 
 
-class DynamicToolManager(ModelManager):
+class DynamicToolManager(ModelManager[model.DynamicTool]):
     """Manages dynamic tools stored in Galaxy's database."""
 
     model_class = model.DynamicTool