Address review comments by @nsoranzo

galaxyproject · May 18, 2016 · 0e3f910 · 0e3f910
1 parent 2de791c
commit 0e3f910
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/lib/galaxy/datatypes/data.py b/lib/galaxy/datatypes/data.py
@@ -66,7 +66,6 @@ class Data( object ):
     """
     edam_data = "data_0006"
     edam_format = "format_1915"
-    edam_data = "data_0006"
     # Data is not chunkable by default.
     CHUNKABLE = False
 

diff --git a/lib/galaxy/datatypes/proteomics.py b/lib/galaxy/datatypes/proteomics.py
@@ -127,7 +127,7 @@ class PepXml(ProteomicsXml):
     file_ext = "pepxml"
     blurb = 'pepXML data'
     root = "msms_pipeline_analysis"
-    
+
 
 class MzML(ProteomicsXml):
     """mzML data"""

diff --git a/lib/galaxy/datatypes/registry.py b/lib/galaxy/datatypes/registry.py
@@ -824,18 +824,14 @@ def get_upload_metadata_params( self, context, group, tool ):
     def edam_formats( self ):
         """
         """
-        mapping = {}
-        for k, v in self.datatypes_by_extension.iteritems():
-            mapping[k] = v.edam_format
+        mapping = dict((k, v.edam_format) for k, v in self.datatypes_by_extension.items())
         return mapping
 
     @property
     def edam_data( self ):
         """
         """
-        mapping = {}
-        for k, v in self.datatypes_by_extension.iteritems():
-            mapping[k] = v.edam_data
+        mapping = dict((k, v.edam_data) for k, v in self.datatypes_by_extension.items())
         return mapping
 
     @property

diff --git a/lib/galaxy/datatypes/text.py b/lib/galaxy/datatypes/text.py
@@ -394,7 +394,7 @@ def set_meta( self, dataset, **kwd ):
 
 
 class SnpEffDb( Text ):
-    """Class describing a SnpEff genome build"""i
+    """Class describing a SnpEff genome build"""
     edam_format = "format_3624"
     file_ext = "snpeffdb"
     MetadataElement( name="genome_version", default=None, desc="Genome Version", readonly=True, visible=True, no_value=None )