This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Remove funcx install from github in the action and move to requirements.txt #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadudoc
approved these changes
Feb 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The old funcx library had a dependency on parsl 0.9 which in turn had a dependency on a version of tornado with a vulnerability.
Solution to
#207
Approach
Moved the install of funcX library from the CI job into
requirements.txtin the development branches we can pick up the library from themainbranch of the funcX repo. For deployed releases we will want to pin this to a version of the funcX library on pypi.Dependabot was flagging a vulnerability in bleach library. Updated that as well