Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle OAuth2AccessTokenErrorResponse exception when attempting to parse access token. #138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mribbons
Copy link
Contributor

@mribbons mribbons commented Aug 7, 2017

This occurs in AuthorizationCode flow when the client secret is
incorrect and the server returns invalid_client.

Without this exception handling, authorization attempt fails silently.

mribbons added 2 commits July 31, 2017 14:56
to parse access token.

This occurs in AuthorizationCode flow when the client secret is
incorrect and the server returns invalid_client.
in invalid_secret scenario. Report error using callback, consumer will receive
{"error":"invalid_secret"} rather than silent failure with no error
callback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant