feat(citations): add UnmatchedCitation model and logic #4949
Conversation
grossir
force-pushed
the
4920-store-unmatched-citations
branch
2 times, most recently
from
78468a9 to
f5b3f35
Compare
grossir
force-pushed
the
4920-store-unmatched-citations
branch
from
f5b3f35 to
e7eac4e
Compare
Solves #4920 - Add new model UnmatchedCitation on citations app - refactor cl.search.models.Citation to create a BaseCitation abstract model to reuse on the UnmatchedCitation model - updates cl.citations.tasks.store_opinion_citations_and_update_parentheticals to handle storing and updating unmatched citations - updates cl.search.signals to update UnmatchedCitation status when a new Citation is saved - add tests - add update_unmatched_citations command to trigger update for found citations
grossir
force-pushed
the
4920-store-unmatched-citations
branch
from
e7eac4e to
e363c90
Compare
|
@flooie this is ready for review. Can you review it or assign someone else? Thanks |
There was a problem hiding this comment.
I didn't read all the code, but I did a quick look through at the models (since I always have opinions about them!). One or two little comments, but I'll leave the rest to others.
This seems well thought out and like a really nice improvement. It's going to be powerful to know which of our citations are the most needed.
- update model and migrations files - update status description and creation, given that an UnmatchedCitation may actually exist on the Citation table, but we are not able to resolve it
|
@quevon24 can you review this please? |
| cls.opinion = cls.cluster.sub_opinions.first() | ||
| UnmatchedCitation.objects.all().delete() | ||
|
|
||
| def test_1st_creation(self) -> None: |
There was a problem hiding this comment.
Maybe split this big test into smaller tests, something like: test_save_unmatched_citations, test_signal_matching_citation and test_single_citation_resolved
There was a problem hiding this comment.
Originally I did it that way; but then I was inheriting from SimpleTestCase and it would break other tests (not precisely sure why).
Then I changed to TransactionTestCase as parent class, but the signal wouldn't work unless they were all in the same function. That's why I ended up putting everything in a single test
You can check the changes in this commit
4304ccb
Solves #4920
cl.search.models.Citationto create a BaseCitation abstract model to reuse on the UnmatchedCitation modelcl.citations.tasks.store_opinion_citations_and_update_parentheticalsto handle storing and updating unmatched citationscl.search.signalsto update UnmatchedCitation status when a new Citation is saved--allargument is passedupdate_unmatched_citationscommand to trigger update for found citations