Use platformdirs to find user configuration files #1059
Merged
+435
−394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almet
force-pushed
the
platformdirs
branch
2 times, most recently
from
560a25c to
b361719
Compare
|
(rebased on top of #1060 to have the CI green. We can probably merge the two together if it makes it easier to ship) |
The previous library we were using for this (`appdirs`) is dead upstream and not supported anymore in debian testing. Fixes #1058
|
Awesome, thanks Alexis! |
apyrgio
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous library we were using for this (
appdirs) is dead upstreamand not supported anymore in debian testing.
Fixes #1058
I haven't bumped the
poetry.lockfile here, and so the CI should be failing because of it, but the reason is that updating it makes the CI fail anyway. We probably should fix it in another PR.