Warn users if the minimum version of Docker Desktop is not met #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almet
force-pushed
the
minimum-docker-desktop-version
branch
from
fcfabf7 to
b67cb9b
Compare
almet
force-pushed
the
minimum-docker-desktop-version
branch
from
b67cb9b to
48ad749
Compare
apyrgio
approved these changes
Jan 20, 2025
|
Tested on Windows and macOS (both Intel and Apple Silicon). The detection seems to work great 🤩 . Thanks a lot for the great work, and again, sorry for the delay. Feel free to merge when you want. (I've added a small comment about a typo that I saw. Feel free to address it and resolve the thread in order to merge this PR) |
almet
force-pushed
the
minimum-docker-desktop-version
branch
from
48ad749 to
23f3ad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only happens on Windows and macOS (faking it here for the need of the video capture).
Fixes #693
Capture.video.du.2024-12-18.14-52-45.mp4