negative sints were not being recorded properly #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now shows them in binary with MSB set Fixes part of interpreter issue #109
ucbjrl
reviewed
Feb 26, 2018
| @@ -482,7 +482,9 @@ case class VCD( | |||
| val initialValues = new mutable.HashSet[Change] | |||
| var scopeRoot = Scope(scope) | |||
| val wires = new mutable.HashMap[String, Wire] | |||
| var aliasedWires = new mutable.HashMap[String, mutable.HashSet[Wire]] { | |||
| var aliasedWires : mutable.HashMap[String, mutable.HashSet[Wire]] = | |||
There was a problem hiding this comment.
Did IntelliJ suggest this change? It looks like a DRY-violation to me.
There was a problem hiding this comment.
yes it did, it's quite particular about public members of classes having explicit declarations.
Simplified rendering of negative BigInt values Fixed poisoned values so they now render in VCD as negative values. This required passing down .poisoned as uninitialized to VCD Added some tests of poisoned.
chick
added a commit
that referenced
this pull request
Mar 13, 2018
in vcd log clock and other one bit signals tracked wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now shows them in binary with MSB set
Fixes part of interpreter issue #109