issue #533: fixed page crashing if mock-fcc-data endpoint is not running #534
Conversation
… is not running
| return data.json(); | ||
| } catch (error) { | ||
| return []; | ||
| } |
There was a problem hiding this comment.
Instead of catching all possible errors, it's better to just do a defensive check to see if data is set properly (as a json). If not, return the empty array.
There was a problem hiding this comment.
@sudo-benjamin - to know what to check, You should read the document of json() method. The exceptions that could be thrown if the JSON can be parsed is SyntaxError. And in other to return to handle a specific error, you will need to do as
if (error instanceof SystemError) { return [] }
There was a problem hiding this comment.
Just check the open issue, and the error we are seeing on the page is TypeError instead of SyntaxError. You should do the check for TypeError instead.
|
Overall, your fix looks good (see my comment). Can you also add a unit test which can check whether the page loads correctly in both cases: (1) the mock endpoint returns data (2) the mock endpoint does not return data). |
|
One other request for this issue: In the case where there is no data to display in the table, it does not look good to show a completely empty table. This might be a confusing user experience. Please show a custom message on the page in place of the table. For now, you could simply remind them to enable the mock-fcc-data endpoint. |
| return data.json(); | ||
| try { | ||
| let data = await fetch(process.env.MOCK_USER_DATA_URL); | ||
| return data.json(); |
There was a problem hiding this comment.
json() doesn't return a JSON but a promise. You need to add await when calling data.json() as well. You can read it more from here.
https://developer.mozilla.org/en-US/docs/Web/API/Response/json
Checklist:
Update index.md)Closes #533