-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): Added hot reloading in our /classes page #357
Conversation
@Komal914 See above. |
@lloydchang yes, I think this may be what is causing the Alerts to disappear, since the page refreshes right after |
Status: @Komal914 confirmed that this #357 is blocking #134 On July 17th, Komal Kaur messaged Lloyd Chang, Guillermo Flores V in CodeDay Labs #help-desk channel at https://codedayorg.slack.com/archives/C05EZKUU456/p1689623550089979?thread_ts=1689278492.275899
Guillermo Flores V replied:
|
My PR is currently in review, sorry about the delay but I cannot merge it myself since I am the PR author. Once the PR is merged we can move to reviewing Komal's PR |
Checklist:
Update index.md
)Closes #365
Our classes page is not currently taking advantage of hot reloading, this PR introduces changes to take advantage of this feature.
Once we load our
/classes
page, we save them into a state. This state will help us keep track of our classes (adding, editing, deleting)We are using our response to build the class into our DOM to ensure that the server and client are always matched together.
Here are GIF comparisons of the two experiences:
Before
Creating a classroom:
Deleting a classroom:
After
Creating a classroom:
Deleting a classroom: