Update chart when props change #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status of this? I would be very happy to see this in master. |
|
Can this be merged asap? |
|
@fraserxu This is desperately needed. Can you please review and merge? |
|
I would love this to be merged too. Right now, this library is not really reactive... |
|
Sry for the late reply, just published to [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 0.14 release of this library removed
componentWillReceivePropsto address warnings from React that this is an unsafe method and will be removed in React 17.x. Unfortunately, this introduced a regression whereupdateChartis no longer called when props change. This PR restores that behavior while still satisfying the unsafe method warning by switchinggetDerivedStateFromPropsto thecomponentDidUpdatelifecycle.Related issues: #88 #84 #83 #73