feat: ✨ replaced title in svg with aria-labelledby="" #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Yolijn
force-pushed
the
fix/svg-title-to-aria-labelledby
branch
from
afa9ede to
7f5bf3a
Compare
Yolijn
force-pushed
the
fix/svg-title-to-aria-labelledby
branch
from
7f5bf3a to
88b1b9a
Compare
Yolijn
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed title in SVG illustrations with aria-labelledby=""
Description
Before, when hovering over the SVG after a few seconds a visible text tooltip would show up, now after changing it to
aria-labelledby="" there is no longer a tooltip showing while still being accessible
Screenshots
Before
after
UI Accessibility Checklist
If your PR includes UI changes, please utilize this checklist:
CriticalandSeriousissues