Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build.scala to build.sbt #186

Merged
merged 3 commits into from
Apr 14, 2016
Merged

Update build.scala to build.sbt #186

merged 3 commits into from
Apr 14, 2016

Conversation

eed3si9n
Copy link
Member

Fixes #184

@xuwei-k
Copy link
Member

xuwei-k commented Apr 13, 2016 

[error] Expected ID character
[error] Not a valid command: giter8-plugin (similar: plugin, plugins)
[error] Expected project ID
[error] Expected configuration
[error] Expected ':' (if selecting a configuration)
[error] Expected key
[error] Not a valid key: giter8-plugin (similar: sbt-plugin, sbtPlugin)
[error] giter8-plugin/scripted
[error]              ^

@xuwei-k
Copy link
Member

xuwei-k commented Apr 14, 2016

👍

@eed3si9n eed3si9n merged commit de429ff into foundweekends:0.6.9 Apr 14, 2016
@eed3si9n eed3si9n deleted the wip/buildsbt branch April 14, 2016 14:37
ches
ches reviewed Apr 14, 2016
View reviewed changes
project/build.scala

val g8version = "0.6.9-SNAPSHOT"

lazy val buildSettings = lsSettings ++ Seq(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the lsSettings weren't carried over—if discontinuing publishing metadata to ls was a conscious decision because ls might be dead (#179), I think we could additionally remove some cruft:

  • The ls-sbt plugin that's being loaded.
  • JSON metadata files in app/src/main/ls, library/src/main/ls, etc.
  • Concatenate the files in notes into one CHANGELOG.md?

This is a separate matter from removing the library support for ls version lookups, which is the subject of #179.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes/ are for notes.implicit.ly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh.

And about ls?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for cleaning up ls stuff.

ches added a commit to ches/giter8 that referenced this pull request Apr 14, 2016
@ches
Remove remnants of ls metadata publishing
c7242f2 
ls is unmaintained (foundweekends#179) and since foundweekends#186 we've removed the configuration
to publish metadata there. Seems there's no longer a need to keep around
the sbt plugin and old metadata, then.
@ches ches mentioned this pull request Apr 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eed3si9n @xuwei-k @ches