Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script init command #1298

Merged
merged 51 commits into from
Feb 19, 2024
Merged

Add script init command #1298

merged 51 commits into from
Feb 19, 2024

Conversation

ddoktorski
Copy link
Contributor

@ddoktorski ddoktorski commented Dec 5, 2023 •
edited
Loading

Closes #1196

Introduced changes

  • Command to initialize template for deployment scripts

Please note that change in the command to run script, namely to have script run <MODULE_NAME> instead of script <MODULE_NAME> will be addressed in a separate PR.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@ddoktorski ddoktorski requested a review from a team as a code owner December 5, 2023 18:34
@ddoktorski ddoktorski requested review from Radinyn, abulenok and THenry14 and removed request for a team December 5, 2023 18:34
THenry14
THenry14 reviewed Dec 6, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
crates/cast/src/main.rs Outdated Show resolved Hide resolved
crates/cast/src/main.rs Outdated Show resolved Hide resolved
crates/cast/src/starknet_commands/script/init.rs Outdated Show resolved Hide resolved
crates/cast/src/starknet_commands/script/init.rs Outdated Show resolved Hide resolved
crates/cast/src/starknet_commands/script/init.rs Outdated Show resolved Hide resolved
crates/cast/src/starknet_commands/script/init.rs Outdated Show resolved Hide resolved
crates/cast/src/starknet_commands/script/init.rs Outdated Show resolved Hide resolved
crates/cast/src/starknet_commands/script/mod.rs Outdated Show resolved Hide resolved
docs/src/appendix/cast/script.md Outdated Show resolved Hide resolved
@THenry14
Copy link
Contributor

THenry14 commented Dec 6, 2023

let's also merge/rebase to master before the next round of review. Overall, great work mate 💪

@ddoktorski ddoktorski requested a review from THenry14 December 7, 2023 16:06
@ddoktorski ddoktorski requested a review from THenry14 February 9, 2024 15:12
@ddoktorski ddoktorski requested review from THenry14 and abulenok and removed request for abulenok and THenry14 February 13, 2024 09:28
@ddoktorski ddoktorski requested a review from abulenok February 15, 2024 14:42
THenry14
THenry14 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nitpicky comments about improving docs and messaging. apart from that, lgtm 👍

crates/sncast/src/starknet_commands/script/init.rs Outdated Show resolved Hide resolved
docs/src/starknet/script.md Show resolved Hide resolved
@ddoktorski
Copy link
Contributor Author

#1733

@ddoktorski ddoktorski requested a review from THenry14 February 19, 2024 14:54
@ddoktorski ddoktorski added this pull request to the merge queue Feb 19, 2024
Merged via the queue into master with commit f46576f Feb 19, 2024
14 checks passed
@ddoktorski ddoktorski deleted the 1196-script-init branch February 19, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THenry14 THenry14 THenry14 approved these changes

@abulenok abulenok Awaiting requested review from abulenok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add script init
3 participants
@ddoktorski @THenry14 @abulenok